Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl lambda calling for the evaluator #1167

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #291

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/Cargo.toml

  • kclvm/evaluator/src/context.rs

  • kclvm/evaluator/src/func.rs

  • kclvm/evaluator/src/lib.rs

  • kclvm/evaluator/src/node.rs

  • kclvm/evaluator/src/scope.rs

  • kclvm/runtime/src/value/val_schema.rs

  • kclvm/evaluator/src/value.rs

  • kclvm/runtime/src/context/api.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/evaluator/src/tests.rs
  • test/grammar/lambda/closure_11/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 27, 2024
@Peefy Peefy self-assigned this Mar 27, 2024
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit c84b12d into kcl-lang:main Mar 27, 2024
6 of 8 checks passed
@Peefy Peefy deleted the feat-evaluator-lambda branch March 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants